Relax <select> parser rules #47179
Merged
Relax <select> parser rules #47179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes <select> allow tags besides <option>, <optgroup>, and <hr>. Previously this was only allowed within a child <button> or <datalist> tag inside <select>, but based on the feedback in whatwg we should try to allow this content everywhere: whatwg/html#10310 This behavior is guarded behind a flag. Since I am planning on shipping parser changes for <select> before appearance:base-select, I am creating a new flag for parser changes instead of reusing the existing StylableSelect flag for appearance:base-select. The new flag is intended to not only make the parser change, but also update the algorithms which associate option/optgroup/hr elements with select elements to account for the newly parsed elements. If everything goes well, then we will need to change these WPTs which this patch effectively marks as failing: html/infrastructure/common-dom-interfaces/collections/htmloptionscollection.html html/semantics/forms/the-select-element/select-value.html html/syntax/parsing/ Bug: 1511354 Change-Id: I441f9645a592ac63764fef928e4e5acf3fdec5db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5518837 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1329137}
wpt-pr-bot
approved these changes
Jul 17, 2024
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5518837
branch
from
3561896
to
2e66cef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes <select> allow tags besides <option>, <optgroup>, and
<hr>. Previously this was only allowed within a child <button> or
<datalist> tag inside <select>, but based on the feedback in whatwg we
should try to allow this content everywhere:
whatwg/html#10310
This behavior is guarded behind a flag. Since I am planning on shipping
parser changes for <select> before appearance:base-select, I am creating
a new flag for parser changes instead of reusing the existing
StylableSelect flag for appearance:base-select. The new flag is intended
to not only make the parser change, but also update the algorithms which
associate option/optgroup/hr elements with select elements to account
for the newly parsed elements.
If everything goes well, then we will need to change these WPTs which
this patch effectively marks as failing:
html/infrastructure/common-dom-interfaces/collections/htmloptionscollection.html
html/semantics/forms/the-select-element/select-value.html
html/syntax/parsing/
Bug: 1511354
Change-Id: I441f9645a592ac63764fef928e4e5acf3fdec5db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5518837
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1329137}