[wptrunner] Delete all cookies after navigating to testharness runner page #48057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-j-lee
force-pushed
the
wptrunner/clear-cookies
branch
from
0d5d41d
to
c181f6c
Compare
... for WebDriver-based browsers. This should fix some flakiness [1] when an unrelated test leaks cookies [2] and the browser is not restarted. Many tests already delete cookies during setup, but this new callsite: 1. Guarantees a clean slate enforced by the harness 2. Works for non-`window` scopes that don't have access to `test_driver.delete_all_cookies()` [1]: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-wpt-chromium-rel/11454/test-results?q=ExactID%3Aninja%3A%2F%2F%3Aheadless_shell_wpt%2Fexternal%2Fwpt%2Ffetch%2Fapi%2Fcredentials%2Fcookies.any.serviceworker.html+VHash%3A0c0dfda1bb530016 [2]: https://github.com/web-platform-tests/wpt/blob/4af0c1ce/fedcm/support/set_cookie.headers
jonathan-j-lee
force-pushed
the
wptrunner/clear-cookies
branch
from
c181f6c
to
b846678
Compare
jonathan-j-lee
changed the title
|
I realized this won't work generally because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... for WebDriver-based browsers. This should fix some flakiness when an unrelated test leaks cookies and the browser is not restarted.
Many tests already delete cookies during setup, but this new callsite:
windowscopes that don't have access totest_driver.delete_all_cookies()