Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass x, y to test_driver_internal.click #48098

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't pass x, y to test_driver_internal.click #48098

wants to merge 1 commit into from

Commits on Sep 11, 2024

  1. Don't pass x, y to test_driver_internal.click 

    This is because the semantics are supposed to be defined by WebDriver,
and that doesn't allow setting the x,y coordinates for the click
command (you have to use Actions for that instead). Therefore
implementations are expected to compute the coordinates rather than
use passed-in values.

By the same argument we could remove the scrollIntoView and initial
check, since those just replicate checks WebDriver already does. Since
that comes with the possibility of timing changes it isn't included in
this change.
    @jgraham
    jgraham committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    23d32be View commit details
    Browse the repository at this point in the history