Skip to content

Commit

Permalink
Update DatePickerModal.tsx
Browse files Browse the repository at this point in the history
  • Loading branch information
RichardLindhout authored Dec 7, 2023
1 parent 60e1ea0 commit 58f8eac
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions src/Date/DatePickerModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -110,16 +110,8 @@ export function DatePickerModal(
<View
style={[
{
height: Platform.select({
ios: StatusBar.currentHeight,
android: StatusBar.currentHeight,
web: insets.top,
}),
backgroundColor: Platform.select({
ios: theme.colors.primary,
android: theme.colors.primary,
web: headerBackgroundColor,
}),
height: insets.top,

This comment has been minimized.

Copy link
@SoyDiego

SoyDiego Dec 8, 2023

Contributor

All the lines that you deleted I added because in Android is NOT ok.

image

My fix was tested in Android, iOS and Web and was working perfectly.
Now in Android is broken (again)

The previous version was like this:

image

Please, fix it again if possible or try to find a way for all devices not only for iOS.

This comment has been minimized.

Copy link
@RichardLindhout

RichardLindhout Dec 8, 2023

Author Member

I'll fix it tomorrow!

This comment has been minimized.

Copy link
@RichardLindhout

RichardLindhout Dec 8, 2023

Author Member

The problem is sometimes user's dont have colored status bar on android, i just have white so there are all kind of use cases :)

This comment has been minimized.

Copy link
@SoyDiego

SoyDiego Dec 8, 2023

Contributor

The problem is sometimes user's dont have colored status bar on android, i just have white so there are all kind of use cases :)

Yes, but if you leave white, the text should be black or something like that. I hope you can find another alternative that works in Android too, or add dynamic ways to see with color or normal. Because this way is not ok unfortunetely.

This comment has been minimized.

Copy link
@SoyDiego

SoyDiego Dec 10, 2023

Contributor

Please @RichardLindhout, I hope you don't forget about this issue and you can find a better solution for all devices.

This comment has been minimized.

Copy link
@SoyDiego

SoyDiego Dec 12, 2023

Contributor

@RichardLindhout will you do the update and fixing for Android too?
If not, can you confirm it or update the README and write something about this library is not maintained?
Because it's true, the last 5 months only @iM-GeeKy and me were doing PRs and no replies of you or any help.
Or maybe start a new fork...

Thanks

backgroundColor: headerBackgroundColor,
},
]}
/>
Expand Down

0 comments on commit 58f8eac

Please sign in to comment.