Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker modal jumps onLoad #309

Closed
MartijnWeijman opened this issue Aug 18, 2023 · 15 comments · Fixed by #316
Closed

DatePicker modal jumps onLoad #309

MartijnWeijman opened this issue Aug 18, 2023 · 15 comments · Fixed by #316
Labels
needs repro Needs reproducible example question Further information is requested repro provided Reproducible example provided

Comments

@MartijnWeijman
Copy link

I have an issue that when I open the DatePickerModal it goes to the Top of the screen and then jumps into the correct position. I'm using for the emulator a Google Pixel 6 Pro and on my physicial device (Flip 3) it has the same issue. Hopefully anyone could help me with this!

@MartijnWeijman MartijnWeijman added the question Further information is requested label Aug 18, 2023
@iM-GeeKy iM-GeeKy added the needs repro Needs reproducible example label Aug 18, 2023
@github-actions
Copy link
Contributor

Hey! Thanks for opening the issue. Can you provide a minimal repro which demonstrates the issue? Posting a snippet of your code in the issue is useful, but it's not usually straightforward to run. A repro will help us debug the issue faster. Please try to keep the repro as small as possible. The easiest way to provide a repro is on snack.expo.dev. If it's not possible to repro it on snack.expo.dev, then you can also provide the repro in a GitHub repository.

@MartijnWeijman
Copy link
Author

Here is a example repo of how I use it in my App: https://github.com/MartijnWeijman/DatePickerExample

@iM-GeeKy iM-GeeKy added the repro provided Reproducible example provided label Aug 20, 2023
@SoyDiego
Copy link
Contributor

Same issue here!
I came here to report the issue but I'm glad you reported.
Hope they can fix soon:
error

@iM-GeeKy
Copy link
Collaborator

PRs are welcome!

@SoyDiego
Copy link
Contributor

PRs are welcome!

I would like to help but I don't find the file CONTRIBUTING.md or a guide to explain how to do the first steps.

@iM-GeeKy
Copy link
Collaborator

PRs are welcome!

I would like to help but I don't find the file CONTRIBUTING.md or a guide to explain how to do the first steps.

https://web-ridge.github.io/react-native-paper-dates/docs/contributing

@SoyDiego
Copy link
Contributor

PRs are welcome!

I would like to help but I don't find the file CONTRIBUTING.md or a guide to explain how to do the first steps.

https://web-ridge.github.io/react-native-paper-dates/docs/contributing

Thanks, I'm new in React Native but I will try to investigate a little bit to try to solve it.

@SoyDiego
Copy link
Contributor

Are you sure the documentation is ok?
I forked the project and I tried to do the first steps and nothing.

problem

@iM-GeeKy
Copy link
Collaborator

iM-GeeKy commented Aug 24, 2023

Are you sure the documentation is ok? I forked the project and I tried to do the first steps and nothing.

problem

Yes, we just had a first time contributor submit a pull request today and they followed the same documentation. It's hard to tell exactly what you're problem is as there isn't enough information to go off of from the video. Some thoughts that come to mind (do you have yarn? Is the project code inside the directory you are currently in?). Perhaps @RichardLindhout has some initial thoughts

@SoyDiego
Copy link
Contributor

Yes, I installed yarn.
I can see the files in my VSCode.
I tried using npm install and I have node_modules but I cannot start the project.

image

Very weird

@SoyDiego
Copy link
Contributor

SoyDiego commented Aug 24, 2023

I was in my work before with Windows.
Now in my home with Linux I followed the docs and I could start the project.
Thanks and sorry for write in this post all this things.

I hope we can fix the problem of the modal

@iM-GeeKy
Copy link
Collaborator

I was in my work before with Windows. Now in my home with Linux I followed the docs and I could start the project. Thanks and sorry for write in this post all this things.

I hope we can fix the problem of the modal

No problem. I don't have a windows machine so I probably wasn't much help. I'll be around if you have any questions though.

@SoyDiego
Copy link
Contributor

SoyDiego commented Aug 24, 2023

@iM-GeeKy I have checked almost all the componentes touching the styles and I couldn't find the problem.
I realized that it's not the modal, it's some component behind it that causes the content behind it to jump.
I reduced the height of the modal to show:

dates problem.

Maybe with this information can help me or guide me in the correct direction to try to fix it.

Thanks again

@SoyDiego
Copy link
Contributor

@RichardLindhout can you give me a tip or any help where I need to look to find the problem.
I have checked and trying with a lot of styles in differents ways in a lot of components with no luck.

thanks

@SoyDiego
Copy link
Contributor

Hi, I have created a PR solving the problem.
I don't know if is the best solution but works.
You can check here: #316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs repro Needs reproducible example question Further information is requested repro provided Reproducible example provided
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants