Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Windows you cannot use yarn bootstrap #314

Closed
SoyDiego opened this issue Aug 28, 2023 · 9 comments
Closed

On Windows you cannot use yarn bootstrap #314

SoyDiego opened this issue Aug 28, 2023 · 9 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@SoyDiego
Copy link
Contributor

SoyDiego commented Aug 28, 2023

Current behaviour

@RichardLindhout @iM-GeeKy
I tried in 3 differents laptops and I always use yarn. I tried to install doing yarn bootstrap and nothing is happening.
All time I was thinking is my problem but inside your project is the only place where is not working.
In Linux works perfectly.

Expected behaviour

Can use in Windows too.

Preview

problem

@SoyDiego SoyDiego added the bug Something isn't working label Aug 28, 2023
@iM-GeeKy
Copy link
Collaborator

Hi @SoyDiego unfortunately I don't have a windows machine, so I'm not sure how much help I can be here to implement and validate a solution. If this is something you want to tackle and open a pull request for that'd be great. I'm sure others might find it useful in the feature that contribute to the project and also use windows.

@iM-GeeKy iM-GeeKy added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 28, 2023
@SoyDiego
Copy link
Contributor Author

SoyDiego commented Aug 28, 2023

Hi @SoyDiego unfortunately I don't have a windows machine, so I'm not sure how much help I can be here to implement and validate a solution. If this is something you want to tackle and open a pull request for that'd be great. I'm sure others might find it useful in the feature that contribute to the project and also use windows.

I don't use Windows.
I have Linux in my laptop and Windows only in my work. In my work I cannot "play" with this things.
I have 2 PR to do right now (maybe solving #298 and #309), but now I have the doubt if in Windows will be ok because sometimes in Linux the alignment change a little bit cause by the font or things like that.

And I'm trying to help but sometimes is difficult when you are alone fighthing with something that you didn't write and you ask for help and anyone reply. Is like the project is dead

@JoanGil
Copy link
Contributor

JoanGil commented Sep 4, 2023

Hi all! I have been investigating a bit this issue since I have a windows machine and it seems that the yarn command is not working because its behavior is changed. I commented the line from the bootstrap.js file, and everything worked like a charm.
# yarn-path "scripts/bootstrap.js"

But, this would probably make the linux version unusable, right?

@iM-GeeKy
Copy link
Collaborator

iM-GeeKy commented Sep 4, 2023

Hi all! I have been investigating a bit this issue since I have a windows machine and it seems that the yarn command is not working because its behavior is changed. I commented the line from the bootstrap.js file:

# yarn-path "scripts/bootstrap.js"

And everything worked like a charm. If you want I could make the pull request.

If commenting it out works, my guess is the bootstrap.js is failing silently on windows. Ideally, I think that addressing that issue would be the better fix as we could pass this along to the folks at paper who seem to be plagued by the same issue.

@JoanGil
Copy link
Contributor

JoanGil commented Sep 4, 2023

Okay, could anyone with linux check that yarn still works? If it works I can do the one-line merge request 😆

@SoyDiego
Copy link
Contributor Author

SoyDiego commented Sep 4, 2023

Okay, could anyone with linux check that yarn still works? If it works I can do the one-line merge request 😆

Thanks @JoanGil.
I tried in Linux and commenting the line continue working, but I don't know if it is the best solution.
Also I tried to implement a try/catch in bootstrap.js in Windows to see if I can get errors or more information but I didn't have anything.

Maybe @JoanGil you can write here in this post your workaround with all the steps that you did to run the project in Windows and use that information temporary until the people of callstack reply us and they help us to find a solution. Will help future users with Windows and with the same problem, your steps.

What do you think, @iM-GeeKy?

Thanks again both

@iM-GeeKy
Copy link
Collaborator

iM-GeeKy commented Sep 4, 2023

I think for now we can add a blurb to our Contributing Guide to provide window users with a workaround until we can find a proper solution. I don't have a windows machine, so this isn't very easy to troubleshoot on my end. If were looking into this along with the try/catch I would verify it even reaches bootstrap.js to begin with which could be achieved quick and dirty with a log statement in the javascript file.

@JoanGil
Copy link
Contributor

JoanGil commented Sep 5, 2023

Okay, I will debug a bit more the error and update the Contributing Guide with the steps I followed to make it work on a Windows machine.

JoanGil added a commit to JoanGil/react-native-paper-dates that referenced this issue Sep 5, 2023
JoanGil added a commit to JoanGil/react-native-paper-dates that referenced this issue Sep 5, 2023
@iM-GeeKy
Copy link
Collaborator

iM-GeeKy commented Oct 9, 2024

Closing for now since we can use the temporary solution provided in the contributing guide

@iM-GeeKy iM-GeeKy closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants