Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make status bar work great in all kind of modes #363

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

RichardLindhout
Copy link
Member

@RichardLindhout RichardLindhout commented Dec 21, 2023

Scherm­afbeelding 2023-12-21 om 19 50 08 Scherm­afbeelding 2023-12-21 om 19 50 30 Scherm­afbeelding 2023-12-21 om 19 52 37 Scherm­afbeelding 2023-12-21 om 19 52 44 Scherm­afbeelding 2023-12-21 om 19 52 59

@iM-GeeKy
Copy link
Collaborator

Let's get rid of some of the commented out code if it's OBE.

@RichardLindhout RichardLindhout merged commit 7082e3b into master Dec 21, 2023
1 check passed
@SoyDiego
Copy link
Contributor

Android continue with problems:

image

@iM-GeeKy
Copy link
Collaborator

iM-GeeKy commented Dec 21, 2023

Screenshot_1703192651

@RichardLindhout This still seems to be an issue on the latest version as @SoyDiego has pointed out. presentationStyle seems to have some affect on it

@RichardLindhout
Copy link
Member Author

This is a bug in the react native statusbar component when inside a modal unfortunaly. I was hoping it was only in the development build of expo and not in production.

facebook/react-native#34350

But on the snack someone provided it does seem to work. Let me try again what's the difference with our stuff

@RichardLindhout
Copy link
Member Author

It does seem like the modalBackground has effect on statusbar somehow..

@RichardLindhout
Copy link
Member Author

It does work in this snack but not on my android emulator... https://snack.expo.dev/@richardlindhout/status-bar-tester

@RichardLindhout
Copy link
Member Author

RichardLindhout commented Dec 23, 2023

It does seem to work if you put

      <StatusBar
        barStyle={'dark-content'}
        translucent
        backgroundColor={'#ffffff'}
      />

In your app.tsx like in example. Only the statusbar does not update itself on android it seems to e.g. light-content if background is dark.

@iM-GeeKy iM-GeeKy deleted the status-bar-fixes branch August 3, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants