Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make it possible to start the week on monday #389

Merged
merged 1 commit into from
May 22, 2024

Conversation

gregoire-jianda
Copy link

Add the option to start weeks on Monday, default behavior is unchanged.

closes #20

@gregoire-jianda
Copy link
Author

gregoire-jianda commented May 16, 2024

I missed the Swiper component, my bad !

@iM-GeeKy
Copy link
Collaborator

iM-GeeKy commented May 16, 2024

Hey @gregoire-jianda I'll try to find some time to pull this down and test it (it might not be until this weekend). I'll let @RichardLindhout take a look too and merge it if he's available. If not, I'll try to find another person to test it out and then we can get it merged 👍🏻. Thanks for the PR though!

Copy link
Member

@RichardLindhout RichardLindhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good, If I fast look at code also height of month is correctly done LGTM (after testing)!

@iM-GeeKy
Copy link
Collaborator

iM-GeeKy commented May 17, 2024

I've started looking at this and it appears the DatePickerInput does not start with Monday even with the startWeekOnMonday set to true (this was iOS, I haven't made it android or web yet). @gregoire-jianda Would you mind taking a look at this? It's looking great though! Nice work!

Signed-off-by: Grégoire Bélorgey <gregoire@jianda.fr>
@gregoire-jianda
Copy link
Author

Good catch @iM-GeeKy, fixed!

@iM-GeeKy
Copy link
Collaborator

Good catch @iM-GeeKy, fixed!

Great job man! We really appreciate the pull request!

@iM-GeeKy iM-GeeKy merged commit 0cf7468 into web-ridge:master May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to start the week on monday
3 participants