Improve Base64UrlSafe performance when ext-sodium is installed #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscni
force-pushed
the
base64-performance
branch
from
ce138fc to
5af2498
Compare
These adjustments are only applying the changes made in paragonie/constant_time_encoding between 2.6.3 and 2.8.2 See: https://github.com/paragonie/constant_time_encoding/compare/v2.6.3..v2.8.2
tscni
force-pushed
the
base64-performance
branch
from
5af2498 to
2d93c73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target branch: 4.1.x
Includes:
Base64UrlSafehas potential for significant performance improvements by usingext-sodium. This in turn improves JWT decoding performance.These adjustments are only applying the changes made in paragonie/constant_time_encoding between 2.6.3 and 2.8.2. It's essentially a dependency update.
See: https://github.com/paragonie/constant_time_encoding/compare/v2.6.3..v2.8.2, paragonie/constant_time_encoding#61
Side effects from the direct application of all changes up to 2.8.2 include:
#[SensitiveParameter]use functionstatements for existing PHP function usagesdecodeNoPadding()