Deleted unnecessary files.#4
Open
YingkaiLi-VM wants to merge 6 commits intoweb3infra-foundation:mainfrom
Open
Conversation
…P/3 has been added.
Signed-off-by: YingkaiLi-VM <c.asm.lyk@gmail.com>
Signed-off-by: YingkaiLi-VM <c.asm.lyk@gmail.com>
Signed-off-by: YingkaiLi-VM <c.asm.lyk@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR removes a large set of legacy/unused SDK, protobuf, and Rust crate sources (primarily under sdk/, proto/, and crates/) to reduce repository footprint and eliminate duplicate/obsolete implementations.
Changes:
- Deleted legacy language SDK artifacts and docs under
sdk/(Python/Go/C++/C header). - Removed protobuf API definitions under
proto/overlayward/v1/. - Removed multiple Rust crates and modules under
crates/(types, gateway, sandbox, policy, data, audit, cli, ffi, sdk, macros, service-common).
Reviewed changes
Copilot reviewed 88 out of 89 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/python/init.py | Removed legacy Python SDK package header/comment stub. |
| sdk/go/doc.go | Removed legacy Go SDK package documentation. |
| sdk/cpp/README.md | Removed legacy C++ SDK README. |
| sdk/c/overlayward.h | Removed generated C header from legacy FFI output path. |
| proto/overlayward/v1/volume.proto | Removed volume service protobuf definitions. |
| proto/overlayward/v1/snapshot.proto | Removed snapshot service protobuf definitions. |
| proto/overlayward/v1/sandbox.proto | Removed sandbox service protobuf definitions. |
| proto/overlayward/v1/resource.proto | Removed resource service protobuf definitions. |
| proto/overlayward/v1/network.proto | Removed network service protobuf definitions. |
| proto/overlayward/v1/inter.proto | Removed inter-sandbox service protobuf definitions. |
| proto/overlayward/v1/file.proto | Removed file service protobuf definitions. |
| proto/overlayward/v1/exec.proto | Removed exec service protobuf definitions. |
| proto/overlayward/v1/event.proto | Removed event service protobuf definitions. |
| proto/overlayward/v1/common.proto | Removed shared protobuf messages. |
| proto/overlayward/v1/audit.proto | Removed audit service protobuf definitions. |
| proto/overlayward/v1/approval.proto | Removed approval service protobuf definitions. |
| crates/ow-types/src/response.rs | Removed legacy API response/pagination types. |
| crates/ow-types/src/models/volume.rs | Removed legacy volume models/requests. |
| crates/ow-types/src/models/snapshot.rs | Removed legacy snapshot models/requests. |
| crates/ow-types/src/models/sandbox.rs | Removed legacy sandbox models/status machine/requests. |
| crates/ow-types/src/models/resource.rs | Removed legacy resource usage/resize models. |
| crates/ow-types/src/models/network.rs | Removed legacy network policy/rules models. |
| crates/ow-types/src/models/mod.rs | Removed legacy models module exports. |
| crates/ow-types/src/models/inter.rs | Removed legacy interconnection/message models. |
| crates/ow-types/src/models/file.rs | Removed legacy file request/entry models and base64 helper. |
| crates/ow-types/src/models/exec.rs | Removed legacy exec/shell models. |
| crates/ow-types/src/models/event.rs | Removed legacy event models/constants. |
| crates/ow-types/src/models/audit.rs | Removed legacy audit models/queries. |
| crates/ow-types/src/models/approval.rs | Removed legacy approval models/filters/decisions. |
| crates/ow-types/src/lib.rs | Removed legacy ow-types crate root exports. |
| crates/ow-types/src/error.rs | Removed legacy API error codes/mapping and error type. |
| crates/ow-types/src/auth.rs | Removed legacy auth/access-level identity types. |
| crates/ow-types/Cargo.toml | Removed legacy ow-types crate manifest. |
| crates/ow-service-common/src/lib.rs | Removed legacy shared service health/config utilities. |
| crates/ow-service-common/Cargo.toml | Removed legacy ow-service-common crate manifest. |
| crates/ow-sdk/src/lib.rs | Removed legacy Rust SDK crate root. |
| crates/ow-sdk/src/error.rs | Removed legacy Rust SDK error mapping. |
| crates/ow-sdk/src/client.rs | Removed legacy Rust SDK gRPC client wrapper. |
| crates/ow-sdk/Cargo.toml | Removed legacy Rust SDK crate manifest. |
| crates/ow-sandbox/src/routes.rs | Removed legacy sandbox REST routes (axum). |
| crates/ow-sandbox/src/mock.rs | Removed legacy sandbox mock backend/store and managers. |
| crates/ow-sandbox/src/lib.rs | Removed legacy sandbox service runner wiring. |
| crates/ow-sandbox/Cargo.toml | Removed legacy ow-sandbox crate manifest. |
| crates/ow-policy/src/mock.rs | Removed legacy policy mock (guardian + approvals). |
| crates/ow-policy/src/lib.rs | Removed legacy policy service runner wiring. |
| crates/ow-policy/Cargo.toml | Removed legacy ow-policy crate manifest. |
| crates/ow-macros/src/lib.rs | Removed legacy procedural macro stubs. |
| crates/ow-macros/Cargo.toml | Removed legacy ow-macros crate manifest. |
| crates/ow-gateway/src/traits.rs | Removed legacy gateway trait interfaces. |
| crates/ow-gateway/src/routes/volume.rs | Removed legacy gateway REST volume routes. |
| crates/ow-gateway/src/routes/snapshot.rs | Removed legacy gateway REST snapshot routes. |
| crates/ow-gateway/src/routes/sandbox.rs | Removed legacy gateway REST sandbox routes. |
| crates/ow-gateway/src/routes/resource.rs | Removed legacy gateway REST resource routes. |
| crates/ow-gateway/src/routes/network.rs | Removed legacy gateway REST network routes. |
| crates/ow-gateway/src/routes/mod.rs | Removed legacy gateway REST route aggregation. |
| crates/ow-gateway/src/routes/inter.rs | Removed legacy gateway REST inter routes. |
| crates/ow-gateway/src/routes/file.rs | Removed legacy gateway REST file routes. |
| crates/ow-gateway/src/routes/exec.rs | Removed legacy gateway REST exec routes. |
| crates/ow-gateway/src/routes/events.rs | Removed legacy gateway REST events routes. |
| crates/ow-gateway/src/routes/audit.rs | Removed legacy gateway REST audit routes. |
| crates/ow-gateway/src/routes/approval.rs | Removed legacy gateway REST approval routes. |
| crates/ow-gateway/src/registry.rs | Removed legacy gateway service registry struct. |
| crates/ow-gateway/src/mock.rs | Removed legacy gateway in-memory mock backend implementations. |
| crates/ow-gateway/src/middleware/mod.rs | Removed legacy gateway middleware module exports. |
| crates/ow-gateway/src/middleware/auth.rs | Removed legacy gateway auth middleware. |
| crates/ow-gateway/src/mcp.rs | Removed legacy MCP server implementation. |
| crates/ow-gateway/src/lib.rs | Removed legacy gateway crate root/service runner. |
| crates/ow-gateway/src/grpc_services.rs | Removed legacy tonic gRPC service implementations. |
| crates/ow-gateway/src/extract.rs | Removed legacy axum extractors (Caller/Json). |
| crates/ow-gateway/src/error.rs | Removed legacy gateway AppError helpers. |
| crates/ow-gateway/src/auth.rs | Removed legacy gateway token resolver. |
| crates/ow-gateway/build.rs | Removed legacy proto compilation build script. |
| crates/ow-gateway/Cargo.toml | Removed legacy ow-gateway crate manifest. |
| crates/ow-ffi/src/lib.rs | Removed legacy Rust FFI bindings implementation. |
| crates/ow-ffi/cbindgen.toml | Removed legacy cbindgen configuration. |
| crates/ow-ffi/build.rs | Removed legacy header generation build script. |
| crates/ow-ffi/Cargo.toml | Removed legacy ow-ffi crate manifest. |
| crates/ow-data/src/mock.rs | Removed legacy data mock backend (volumes/network/inter). |
| crates/ow-data/src/lib.rs | Removed legacy data service runner wiring. |
| crates/ow-data/Cargo.toml | Removed legacy ow-data crate manifest. |
| crates/ow-cli/src/output.rs | Removed legacy CLI output formatting helpers. |
| crates/ow-cli/src/lib.rs | Removed legacy CLI command wiring/execution logic. |
| crates/ow-cli/src/commands.rs | Removed legacy CLI command definitions/args. |
| crates/ow-cli/src/client.rs | Removed legacy CLI HTTP client wrapper. |
| crates/ow-cli/Cargo.toml | Removed legacy ow-cli crate manifest. |
| crates/ow-audit/src/mock.rs | Removed legacy audit mock backend and event manager. |
| crates/ow-audit/src/lib.rs | Removed legacy audit service runner wiring. |
| crates/ow-audit/Cargo.toml | Removed legacy ow-audit crate manifest. |
Comments suppressed due to low confidence (2)
proto/overlayward/v1/common.proto:1
- This PR removes the protobuf definitions under
proto/overlayward/v1, but the repositoryMakefilestill definesPROTO_DIR := protoand uses$(wildcard proto/overlayward/v1/*.proto)formake gen-go/gen-python/gen-cpp. Either keep the proto sources (or move them and updateMakefile), or remove/update those generation targets so they don't fail.
crates/ow-ffi/Cargo.toml:1 ow-ffi(and the generated C header insdk/c/overlayward.h) is removed here, butMakefilestill runscargo build -p ow-ffias part ofmake gen-c/gen-all. Please update/remove the Makefile targets (and any other tooling) to avoid broken generator commands after these deletions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.