WIP: possible node-gyp-native cleanup #465
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't work as-is, these were just some experiments I did, before finding smaller work around in #464 |
hyunjae92-shin
pushed a commit
to webosose/meta-webosose
that referenced
this pull request
Jun 29, 2022
:Release Notes: Fixes: ERROR: node-gyp-packages-native-0.12.2-r0 do_unpack: QA Issue: node-gyp-packages-native: SRC_URI uses PN not BPN [src-uri-bad] :Detailed Notes: For other node-gyp-native fixes see: webOS-ports/meta-webos-ports@812672d webOS-ports/meta-webos-ports@29f569b webOS-ports/meta-webos-ports@1c72a66 webOS-ports/meta-webos-ports@7a21203 webOS-ports/meta-webos-ports@3af337e webOS-ports/meta-webos-ports@0941218 and webOS-ports/meta-webos-ports#465 :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRN-9458] NPM registry should be accessed over https now [WRN-9820] Create GPVB with Yocto 3.5 Kirkstone Change-Id: If4c819d628fa9cb382ce682f160c1820508384d5
shr-project
force-pushed
the
jansa/node-gyp-node-16
branch
from
9d9ee0e to
3ed248f
Compare
|
@shr-project Do we still need this or can we close this one? |
still needed to resolve eventually |
shr-project
force-pushed
the
master
branch
2 times, most recently
from
c1bcdb8 to
ff421f5
Compare
|
@shr-project node-sqlite we're not using anymore in general I guess (was mainly used for the https-everywhere which we used in our old QtWebEngine based browser), so that should make the node-gyp stuff a bit easier? |
shr-project
force-pushed
the
jansa/node-gyp-node-16
branch
from
3ed248f to
0b8d1bc
Compare
|
I don't really remember what were remaining issues with this but I think the webos-nodejs-webos-* didn't build with this yet. I've rebased the changes just to see what's left. I don't remember how this relates to node-sqlite. |
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
…e node-gyp recipes Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
…node-gyp-native Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
shr-project
force-pushed
the
jansa/node-gyp-node-16
branch
from
0b8d1bc to
6591b1e
Compare
shr-project
force-pushed
the
master
branch
2 times, most recently
from
3dabd23 to
2936d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.