-
Notifications
You must be signed in to change notification settings - Fork 0
Fix Three.js example marker detection failure #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
The
threejs_ES6_example.htmlwas failing to detect markers because the initialization logic inthreejs_worker_ES6.jswas fetching the marker image file as a raw ArrayBuffer (containing encoded JPEG bytes) and sending it to the worker. The tracking library expects decoded raw pixel data.This change modifies
threejs_worker_ES6.jsto:Imageobject.getImageData.This ensures the tracker is initialized with the correct reference image data, resolving the detection issue.
PR created automatically by Jules for task 1365532711736261522 started by @kalwalt