Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reporter.ts to allow for multiple CaseIDs #284

Merged
merged 12 commits into from
Jan 18, 2024

Conversation

spencerlavallesonos
Copy link
Contributor

E.g.

it('C00001 C00002 should do two things', async function () {...

E.g. 

it(`C00001 C00002 should do two things`)...
Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, mind adding some unit tests for this?

@spencerlavallesonos
Copy link
Contributor Author

@christian-bromann Been trying to mock up all the testStats and have run into a roadblock, namely with TestStat's private _stringifyDiffObjs.

Could use some assistance.

I have some mockable test JSONs but am getting tripped up on mocking that essential property.

@christian-bromann
Copy link
Contributor

How can I assist?

@spencerlavallesonos
Copy link
Contributor Author

spencerlavallesonos commented Jan 10, 2024

@christian-bromann Looking for some insight on how best to mock the TestStats object parameter for the various onTest* hooks.

Currently having difficulty around some of the @wdio/reporter.TestStats keys & types. Do you have an example unit test that uses TestStats that I can reference?

src/reporter.ts Outdated Show resolved Hide resolved
@spencerlavallesonos
Copy link
Contributor Author

@christian-bromann Unit tests have been added, and updated README to illustrate usage.

@spencerlavallesonos
Copy link
Contributor Author

@christian-bromann Hi Christian, I see that there's a status check failing regarding test/build, however none of the change I made are related to that failing status check. Can you take a look?

@christian-bromann
Copy link
Contributor

mhm .. not sure where it comes from, mind pushing a fix for it into this working branch?

@christian-bromann
Copy link
Contributor

@spencerlavallesonos can we update the Node.js version within the pipeline to Node v18?

@spencerlavallesonos
Copy link
Contributor Author

@spencerlavallesonos can we update the Node.js version within the pipeline to Node v18?

@christian-bromann I've updated the node-version matrix to run from v[18.x, 20.x]

@christian-bromann
Copy link
Contributor

This does the trick but unfortunately there seem to be 2 eslint issues now.

@spencerlavallesonos
Copy link
Contributor Author

This does the trick but unfortunately there seem to be 2 eslint issues now.

Yep yep, sorry for all the back and forth, I'll make it squeaky clean now. 🖖

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎉 Thanks a lot!

@christian-bromann christian-bromann merged commit fa6e561 into webdriverio-community:main Jan 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants