Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support string array for ArgParams #120

Merged

Conversation

traeok
Copy link
Contributor

@traeok traeok commented May 29, 2024

This PR adds support for the string[] type when passing arguments to VS Code.
One use case that this enables is installing multiple extensions for a test scenario using the --install-extension parameter.

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok marked this pull request as ready for review May 29, 2024 15:10
traeok added 2 commits May 29, 2024 13:33
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@christian-bromann christian-bromann self-assigned this Jun 12, 2024
Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thank you!

@christian-bromann christian-bromann merged commit 086e39d into webdriverio-community:main Jun 13, 2024
1 of 9 checks passed
@wdio-bot
Copy link
Collaborator

Hey traeok 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants