fix: handle array return values in multiremote for toHaveText and toH…#1984
Closed
mccmrunal wants to merge 1 commit intowebdriverio:mainfrom
Closed
fix: handle array return values in multiremote for toHaveText and toH…#1984mccmrunal wants to merge 1 commit intowebdriverio:mainfrom
mccmrunal wants to merge 1 commit intowebdriverio:mainfrom
Conversation
|
|
mccmrunal
force-pushed
the
fix/multiremote-expect
branch
from
ae0df6b to
96b86f3
Compare
Contributor
|
👋 We might consider also this PR since some design was stated there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toHaveText
to detect if getText() returns an array. If so, it iterates over the results and verifies that all instances match the expectation.
toHaveTitle
to handle array returns from browser.getTitle() similarly.
Added support for mixed expectations using array syntax.
tested it against the repo given in the issue #1966
and this should fix #106 too