feat: Support basic non-promises matchers with Soft assertion#2006
Open
dprevost-LMI wants to merge 6 commits intowebdriverio:mainfrom
Open
feat: Support basic non-promises matchers with Soft assertion#2006dprevost-LMI wants to merge 6 commits intowebdriverio:mainfrom
dprevost-LMI wants to merge 6 commits intowebdriverio:mainfrom
Conversation
Contributor
Author
|
Requires merge of #1991 |
fix bad command Review `toHaveText` test case for current behaviour and inconsistencies Fix rebase Review toHaveText.test.ts Enrich toHaveText with more test cases Add command validating the build is under the right path Fix mock - Missing parent for $$ selector name in failure message - Better support of filtered ElementArray - `elementArray.props.length` is not a thing length is not directly on ElementArray Better factory + fix missing element's parent Final mock version with everything + toHaveText more tests
- fix `.not` not working for basic matchers - Use soft for all `to` matchers - Use a non async version for basic matchers
dprevost-LMI
force-pushed
the
fix-softAssetion-not-working-with-basic-matchers
branch
from
f56925b to
da8a72d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1887
to