Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-file-manager): use precalculated asset size and add logging #4281

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

Pavel910
Copy link
Collaborator

Changes

This PR fixes several issues with asset delivery:

  • use precalculated asset size to avoid loading asset into Lambda function's memory
  • improve query parameter parsing and asset options handling
  • add logging for more visibility in CloudWatch

How Has This Been Tested?

Manually, by uploading large image and video files, and requesting them via the delivery endpoint, with various options.

@Pavel910 Pavel910 self-assigned this Sep 18, 2024
@Pavel910 Pavel910 added this to the 5.39.14 milestone Sep 18, 2024
@Pavel910 Pavel910 merged commit bc771b0 into 5.39.14 Sep 18, 2024
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant