Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implementation issue of convTranspose2d to support options.groups #51

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fix implementation issue of convTranspose2d to support options.groups #51

merged 2 commits into from
Nov 16, 2023

Conversation

BruceDai
Copy link
Contributor

@BruceDai BruceDai commented Nov 6, 2023

@fdwr @huningxin PTAL, thanks.

huningxin
huningxin reviewed Nov 6, 2023
View reviewed changes
src/conv_transpose2d.js Outdated Show resolved Hide resolved
src/lib/validate-input.js Show resolved Hide resolved
src/lib/validate-input.js Outdated Show resolved Hide resolved
@BruceDai
Copy link
Contributor Author

BruceDai commented Nov 7, 2023

Thanks @huningxin for reviewing. I've updated commit to address your comments, please take another look.

huningxin
huningxin approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@huningxin huningxin merged commit d639b2a into webmachinelearning:main Nov 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huningxin huningxin huningxin approved these changes

@fdwr fdwr fdwr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BruceDai @huningxin @fdwr