Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement expand #57

Merged
merged 3 commits into from
Nov 28, 2023
Merged

implement expand #57

merged 3 commits into from
Nov 28, 2023

Conversation

Mei0211
Copy link

@Mei0211 Mei0211 commented Nov 22, 2023

@Mei0211 Mei0211 changed the title add expand.js and expand_test.js implement expand Nov 22, 2023
BruceDai
BruceDai reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@BruceDai BruceDai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mei0211!
Let's add a more test for testing 0D expand to ND.

test/expand_test.js Outdated Show resolved Hide resolved
@BruceDai BruceDai mentioned this pull request Nov 22, 2023
Merged
huningxin
huningxin reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % other reviewers' comments, thanks!

fdwr
fdwr approved these changes Nov 23, 2023
View reviewed changes
Copy link

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barring remaining comments, LGTM. TY.

@Mei0211
Copy link
Author

Mei0211 commented Nov 27, 2023

I have modified the expand function and added more cases. PTAL,thanks!

@BruceDai
Copy link
Contributor

LGTM, thanks @Mei0211

@huningxin huningxin merged commit a8798d2 into webmachinelearning:main Nov 28, 2023
3 checks passed
@huningxin huningxin mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huningxin huningxin huningxin left review comments

@BruceDai BruceDai BruceDai left review comments

@fdwr fdwr fdwr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mei0211 @BruceDai @huningxin @fdwr @mei1127