Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing <details open> tags #445

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

wchao1115
Copy link
Collaborator

@wchao1115 wchao1115 commented Aug 9, 2023

Fix a few missing

tags for the relevant dev notes to stay consistent with the new style convention.


Preview | Diff

…tay consistent with the new style convention.
@wchao1115 wchao1115 requested a review from zolkis August 9, 2023 06:03
@zolkis
Copy link
Collaborator

zolkis commented Aug 9, 2023

I am fine with that, if you think it makes sense to collapse the notes.

Copy link
Collaborator

@zolkis zolkis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@anssiko anssiko self-requested a review August 9, 2023 10:05
@wchao1115
Copy link
Collaborator Author

I am fine with that, if you think it makes sense to collapse the notes.

Not every note. Just the ones with pseudo code that shows how an operator can be decomposed. The reason is this is one of the design principles of webnn when it comes to its ability to support fusions. We agreed at the time to highlight these sections in the doc with <div class="note">. I simply searched all the occurrences of the word "emulated" in the note section in the doc and make them consistent style-wise. I'm pushing a change here to the zk-convention-integration branch as part of my review so that when all is clear, we can merge the branch wholesale to main then delete it.

@wchao1115
Copy link
Collaborator Author

Thanks

If you're ok with the change, please approve the PR. Thanks!

@wchao1115 wchao1115 merged commit a799197 into zk-conventions-integration Aug 9, 2023
1 check passed
@wchao1115 wchao1115 deleted the wchao_fix_dev_notes branch August 9, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants