Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Remove null value support in reshape()'s newShape parameter #505

Merged
merged 1 commit into from
Jan 20, 2024

Commits on Jan 18, 2024

  1. Bug fix: Remove null value support in reshape()'s newShape parameter

    As noted in issue webmachinelearning#388, the reshape op build method currently supports
    a special null value in newShape array that instructs the
    implementation to compute the size of the dimension with the value
    null so that the total size remains constant. @fwdr proposed WebNN
    should only support the concrete values in newShape because this can
    be easily handled by framework through shape inference
    
    It appears this change has already landed in the Chromium
    implementation and WPTs.
    
    Fixes webmachinelearning#388
    inexorabletash committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    ab36f0d View commit details
    Browse the repository at this point in the history