Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylistic change: Fix indentation of steps validating bias option #509

Merged

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented Jan 16, 2024

Validation of the passed bias option only makes sense if the option is actually supplied. Correct the indentation for a few substeps.


💥 Error: 400 Bad Request 💥

PR Preview failed to build. (Last tried on Jan 16, 2024, 8:42 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

Validation of the passed bias option only makes sense if the option is
actually supplied. Correct the indentation for a few substeps.
Copy link
Collaborator

@zolkis zolkis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a bug fix, makes sense.
I suggest merging ASAP.

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@huningxin huningxin merged commit 69aeffa into webmachinelearning:main Jan 17, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Jan 17, 2024
SHA: 69aeffa
Reason: push, by huningxin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@inexorabletash inexorabletash deleted the style-validate-bias branch January 17, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants