Wording change: Prefix literal lists with "the list" #515
Conversation
There was a problem hiding this comment.
LGTM, thanks @inexorabletash !
@anssiko @wchao1115 @zolkis , PTAL. Thanks!
|
BTW, the PR preview keeps failing on build. Do we know what happens? @anssiko |
|
@dontcallmedom can you see why PR Preview is failing? Here's what I've found: A re-build (by editing the OP comment) did not fix this. The error log suggests https://api.csswg.org/bikeshed/ dies when we pass the bs source to it. This failure first appeared in #469, so I have a nagging feeling PR Preview does not like the |
|
Looks good and I like this compact version. |
|
We were probably able to root-cause the PR Preview failure in #516 (and if not, more helping hands welcome!). @inexorabletash you need to rebase this PR to pull in the fix. The same for other PRs with failing PR Previews, but let's first test here if this is a proper fix. |
|
@huningxin @inexorabletash PR Preview bug has been fixed. Instructions on how to re-trigged PR Preview to produce valid Preview | Diff links in #516 (comment) The same applies to any other open PR where PR Preview is failing. |
inexorabletash
force-pushed
the
wording-the-list
branch
from
aec3429
to
808384d
Compare
|
A rebase seems to have done it, Preview | Diff links showing. 🥳 |
Infra convention and recommended by webmachinelearning#211 - rather than the just «» syntax, specify the Infra type of "list" and link to the definition.
inexorabletash
force-pushed
the
wording-the-list
branch
from
808384d
to
7f0cd70
Compare
SHA: c604f70 Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Infra convention and recommended by #211 - rather than the just «» syntax, specify the Infra type of "list" and link to the definition.
Preview | Diff