Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording change: Use Infra's "Set ... to ..." pattern for properties #517

Merged

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented Jan 18, 2024

"Let ... be ..." is reserved for declaring variables.

For #450


Preview | Diff

"Let ... be ..." is reserved for declaring variables.

For webmachinelearning#450
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@huningxin huningxin merged commit 120e697 into webmachinelearning:main Jan 23, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Jan 23, 2024
SHA: 120e697
Reason: push, by huningxin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@inexorabletash inexorabletash deleted the wording-infra-let-set branch January 23, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants