Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid "sequence" in prose, linkify use in types #729

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented Jul 17, 2024

Per the spec processing model, algorithms don't usually deal with a sequence type; the JS value has been converted to an Infra list. So try to avoid using that term in prose, especially as it is confusing for recurrent operators which have temporal sequences as well. But do call out an exception: unpacking unions.

When used in an IDL type description, though, do linkify it.

Fix a few other grammar/link glitches, too.


Preview | Diff

Per the spec processing model, algorithms don't usually deal with a
sequence<T> type; the JS value has been converted to an Infra list. So
try to avoid using that term in prose, especially as it is confusing
for recurrent operators which have temporal sequences as well. But do
call out an exception: unpacking unions.

When used in an IDL type description, though, do linkify it.

Fix a few other grammar/link glitches, too.
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
fdwr and others added 2 commits July 18, 2024 16:45
Co-authored-by: Dwayne Robinson <dwayner@microsoft.com>
@inexorabletash
Copy link
Member Author

Merge when ready!

Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr fdwr merged commit c4de3ef into webmachinelearning:main Jul 18, 2024
2 checks passed
@inexorabletash inexorabletash deleted the linkify-sequence branch July 19, 2024 00:07
github-actions bot added a commit that referenced this pull request Jul 19, 2024
SHA: c4de3ef
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants