Update dimension valid range to signed integer #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It occurs to me the existing verbiage "Implementations may impose a smaller upper bound" technically already covered this case, since CoreML and TFLite impose a smaller bound (2 billion) than the DML EP (4 billion). Though, I'm content with this restriction, since 2 billion is well more than enough for a single dimension (never saw a model that even came close to that in half a decade for a single tensor). |
fdwr
approved these changes
Jul 24, 2024
github-actions bot
added a commit
that referenced
this pull request
Jul 24, 2024
SHA: 71dd440 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #734
Update
valid dimensiondefinition to be in the range oflongand greater than 0.@fdwr @huningxin
Preview | Diff