Compatible ES6. fix webofthings/webofthings.js#3 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very neat, thanks for the PR. Merging now! |
|
I actually had to revert the PR after I noticed one of the tests failed. The issue is that for actions we register two observers: one for Websockets subscribers (in websockets.js) one for the Plugin used to listen for incoming Actions in CorePlugin.js. With the PR one "observer" overrides the other. Will look for a way around it, thanks again for showing us the direction! |
|
It's very strange, because i modify the 2 files websocket abd coreplugin, one for Array the Other for Object. So not the same class, i don't understand where is the the overrides. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lightweigh fix for #3.
Maybe use of EventEmitter could be safer