Fix for webOS 3.0 + Workflows to produce artifacts #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under webOS 3.0, there were 2 issues: - The call to addDevice didn't work, because mandatory parameters are missing (I suspect they are optional under other versions of webOS) - The call to addDevice only worked once, and failed afterwards because the app is already registered, and the code considered it a fatal error, so didn't go through and stopped before actually launching the hbchannel autostart service. Maybe under different versions of webOS, adding a pre-existing app through addDevice is considered a no-op by luna service and doesn't return an error, but under webOS 3.0 at least, this fails. Modify the code to recognize this exact error and consider it a success. Added some comments and more logs to help debugging potential future cases.
Version 0.1.3 (and previous versions) were not working accross more than two reboots, at least under webOS 3.4. This is because we get relaunched only on the reboot immediately following a successful addDevice call, so this version now ensures that we remove/re-add ourselves from the input app list every time, which guarantees that it works for all next reboots. The relaunch of the previous input app is now done as soon as possible, because this is what gives back control to the user, while we can continue our setup in the background.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the autostart for webOS 3.0, as explained in webosbrew/webos-homebrew-channel#124 (comment)
I also added a GitHub workflow to automatically build and produce an artifact (
.ipk) for each pull request. This artifact can be used to test/verify, and also copied over to a public release if needed, when code is merged to main. Artifacts are only downloadable by accounts with rights on the repository. If you're not comfortable with using GitHub actions for this repo, I can re-make the PR without the workflow.