test: side effects (#109)

webpack-contrib · Jun 23, 2020 · 748798b · 748798b
1 parent 04c1fa7
commit 748798b
Show file tree

Hide file tree

Showing 7 changed files with 154 additions and 3 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -69,6 +69,7 @@
     "memfs": "^3.2.0",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.0.5",
+    "rx": "^4.1.0",
     "standard-version": "^8.0.0",
     "webpack": "^4.43.0"
   },

diff --git a/src/index.js b/src/index.js
@@ -27,7 +27,7 @@ export default function loader() {
   /*
    * Workaround until module.libIdent() in webpack/webpack handles this correctly.
    *
-   * fixes:
+   * Fixes:
    * - https://github.com/webpack-contrib/expose-loader/issues/55
    * - https://github.com/webpack-contrib/expose-loader/issues/49
    */
@@ -47,7 +47,7 @@ export default function loader() {
 
   // Change the request from an /abolute/path.js to a relative ./path.js.
   // This prevents [chunkhash] values from changing when running webpack builds in different directories.
-  const newRequest = contextify(this.rootContext, getRemainingRequest(this));
+  const newRequest = contextify(this.context, getRemainingRequest(this));
   const stringifiedNewRequest = stringifyRequest(this, `-!${newRequest}`);
 
   let code = `var ___EXPOSE_LOADER_IMPORT___ = require(${stringifiedNewRequest});\n`;

diff --git a/test/__snapshots__/loader.test.js.snap b/test/__snapshots__/loader.test.js.snap
@@ -749,6 +749,116 @@ Object {
 
 exports[`loader should work with multiple exposes: warnings 1`] = `Array []`;
 
+exports[`loader should work with side-effects free modules: errors 1`] = `Array []`;
+
+exports[`loader should work with side-effects free modules: module 1`] = `
+"var ___EXPOSE_LOADER_IMPORT___ = require(\\"-!./rx.all.js\\");
+var ___EXPOSE_LOADER_GET_GLOBAL_THIS___ = require(\\"../../../src/runtime/getGlobalThis.js\\");
+var ___EXPOSE_LOADER_GLOBAL_THIS___ = ___EXPOSE_LOADER_GET_GLOBAL_THIS___();
+___EXPOSE_LOADER_GLOBAL_THIS___[\\"myGlobal\\"] = ___EXPOSE_LOADER_IMPORT___;
+module.exports = ___EXPOSE_LOADER_IMPORT___;
+"
+`;
+
+exports[`loader should work with side-effects free modules: result 1`] = `
+Object {
+  "ExposeLoader": Object {
+    "default": [Function],
+  },
+  "global-commonjs2-single-export": Object {
+    "foo": "bar",
+  },
+  "myGlobal": Object {
+    "AnonymousObservable": [Function],
+    "AnonymousObserver": [Function],
+    "AnonymousSubject": [Function],
+    "ArgumentOutOfRangeError": [Function],
+    "AsyncSubject": [Function],
+    "BehaviorSubject": [Function],
+    "BinaryDisposable": [Function],
+    "CompositeDisposable": [Function],
+    "CompositeError": [Function],
+    "ConnectableObservable": [Function],
+    "Disposable": [Function],
+    "EmptyError": [Function],
+    "FlatMapObservable": [Function],
+    "HistoricalScheduler": [Function],
+    "MockDisposable": [Function],
+    "NAryDisposable": [Function],
+    "NotImplementedError": [Function],
+    "NotSupportedError": [Function],
+    "Notification": [Function],
+    "ObjectDisposedError": [Function],
+    "Observable": [Function],
+    "ObservableBase": [Function],
+    "Observer": [Function],
+    "Pauser": [Function],
+    "ReactiveTest": Object {
+      "created": 100,
+      "disposed": 1000,
+      "onCompleted": [Function],
+      "onError": [Function],
+      "onNext": [Function],
+      "subscribe": [Function],
+      "subscribed": 200,
+    },
+    "Recorded": [Function],
+    "RefCountDisposable": [Function],
+    "ReplaySubject": [Function],
+    "Scheduler": [Function],
+    "SerialDisposable": [Function],
+    "SingleAssignmentDisposable": [Function],
+    "Subject": [Function],
+    "Subscription": [Function],
+    "TestScheduler": [Function],
+    "TimeoutError": [Function],
+    "VirtualTimeScheduler": [Function],
+    "config": Object {
+      "Promise": [Function],
+      "longStackSupport": false,
+      "useNativeEvents": false,
+    },
+    "doneEnumerator": Object {
+      "done": true,
+      "value": undefined,
+    },
+    "helpers": Object {
+      "defaultComparer": [Function],
+      "defaultError": [Function],
+      "defaultKeySerializer": [Function],
+      "defaultNow": [Function],
+      "defaultSubComparer": [Function],
+      "identity": [Function],
+      "isArrayLike": [Function],
+      "isFunction": [Function],
+      "isIterable": [Function],
+      "isPromise": [Function],
+      "iterator": Symbol(Symbol.iterator),
+      "noop": [Function],
+      "notImplemented": [Function],
+      "notSupported": [Function],
+    },
+    "internals": Object {
+      "AbstractObserver": [Function],
+      "Enumerable": [Function],
+      "PriorityQueue": [Function],
+      "SchedulePeriodicRecursive": [Function],
+      "ScheduledItem": [Function],
+      "ScheduledObserver": [Function],
+      "addProperties": [Function],
+      "addRef": [Function],
+      "bindCallback": [Function],
+      "inherits": [Function],
+      "isEqual": [Function],
+      "isObject": [Function],
+      "tryCatch": [Function],
+    },
+  },
+}
+`;
+
+exports[`loader should work with side-effects free modules: warnings 1`] = `Array []`;
+
 exports[`loader should work: errors 1`] = `Array []`;
 
 exports[`loader should work: module 1`] = `

diff --git a/test/fixtures/side-effects.js b/test/fixtures/side-effects.js
@@ -0,0 +1,7 @@
+import 'rx';
+
+function test() {
+  return 'test';
+}
+
+export default test;
diff --git a/test/helpers/getCompiler.js b/test/helpers/getCompiler.js
@@ -19,7 +19,7 @@ export default (fixture, loaderOptions = {}, config = {}) => {
     module: {
       rules: [
         {
-          test: /global-.+\.js/i,
+          test: /(global-.+|rx\.all)\.js/i,
           rules: [
             {
               loader: path.resolve(__dirname, '../../src'),

diff --git a/test/loader.test.js b/test/loader.test.js
@@ -1,3 +1,6 @@
+/**
+ * @jest-environment node
+ */
 import path from 'path';
 
 import webpack from 'webpack';
@@ -13,6 +16,8 @@ import {
   readAsset,
 } from './helpers';
 
+jest.setTimeout(30000);
+
 describe('loader', () => {
   it('should work', async () => {
     const compiler = getCompiler('simple-commonjs2-single-export.js', {
@@ -465,4 +470,26 @@ describe('loader', () => {
     expect(getErrors(stats)).toMatchSnapshot('errors');
     expect(getWarnings(stats)).toMatchSnapshot('warnings');
   });
+
+  it('should work with side-effects free modules', async () => {
+    const compiler = getCompiler(
+      'side-effects.js',
+      {
+        exposes: 'myGlobal',
+      },
+      {
+        mode: 'production',
+      }
+    );
+    const stats = await compile(compiler);
+
+    expect(getModuleSource('rx.all-exposed.js', stats)).toMatchSnapshot(
+      'module'
+    );
+    expect(
+      execute(readAsset('main.bundle.js', compiler, stats))
+    ).toMatchSnapshot('result');
+    expect(getErrors(stats)).toMatchSnapshot('errors');
+    expect(getWarnings(stats)).toMatchSnapshot('warnings');
+  });
 });