feat: add built in .env support #4392
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Load env vars at build time and run time
|
|
||
| const WebpackCLI = require("./webpack-cli"); | ||
|
|
||
| const runCLI = async (args: Parameters<IWebpackCLI["run"]>[0]) => { | ||
| // Load environment variables from .env files | ||
| try { |
There was a problem hiding this comment.
I'm not sure that we want the env plugin to be default without any configuration. We should check if an env flag passed to the CLI/API is present.
There was a problem hiding this comment.
I added a --env-file flag for loading in variables from env files into webpack.config.js, but I've made the env plugin added by default so env vars can be accessed from bundled code without having to add the DotenvWebpackPlugin.
Is this what you meant?
Add support for import.meta.env and introduce --env-file flag to load environment variables from .env files into the bundled files. - Support for import.meta.env in webpack builds - New --env-file CLI flag for specifying whether to load .env files for configuration - Renamed dotenv plugin for clarity
- Add documentation for the dotenv webpack plugin - Add --env-file flag to OPTIONS.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature:
.envfile support following Vite's conventionsWEBPACK_are exposed to Webpack-processed codewebpack.config.jsDid you add tests for your changes?
Will add
If relevant, did you update the documentation?
Will add
Summary
Closes #3747
Does this PR introduce a breaking change?
No
Other information
This is my first PR, so there'll probably be a few mistakes / many questions