addLink: support dynamic links added from behaviors (#69)

* addLink: support dynamic links added from behaviors
autoscroll:
- detect if page url (pathname, not hash) changes when scrolling and abort scroll
- call addLink() with new page url
support running main behavior in replay top frame

* remove commented out code

package.json

@@ -1,6 +1,6 @@
 {
   "name": "browsertrix-behaviors",
-  "version": "0.5.2",
+  "version": "0.5.3",
   "main": "index.js",
   "author": "Webrecorder Software",
   "license": "AGPL-3.0-or-later",

src/autoplay.ts

@@ -41,7 +41,7 @@ export class Autoplay extends BackgroundBehavior {
     const run = true;
 
     if (this.polling) {
-      return
+      return;
     }
 
     this.polling = true;

src/autoscroll.ts

@@ -1,5 +1,5 @@
 import { Behavior } from "./lib/behavior";
-import { sleep, waitUnit, xpathNode, isInViewport, waitUntil } from "./lib/utils";
+import { sleep, waitUnit, xpathNode, isInViewport, waitUntil, behaviorLog, addLink } from "./lib/utils";
 import { type AutoFetcher } from "./autofetcher";
 
 
@@ -11,6 +11,8 @@ export class AutoScroll extends Behavior {
   lastScrollPos: number;
   samePosCount: number;
 
+  origPath: string;
+
   constructor(autofetcher: AutoFetcher) {
     super();
 
@@ -24,6 +26,8 @@ export class AutoScroll extends Behavior {
 
     this.lastScrollPos = -1;
     this.samePosCount = 0;
+
+    this.origPath = document.location.pathname;
   }
 
   static id = "Autoscroll";
@@ -113,6 +117,13 @@ export class AutoScroll extends Behavior {
     let lastScrollHeight = self.document.scrollingElement.scrollHeight;
 
     while (this.canScrollMore()) {
+      if (document.location.pathname !== this.origPath) {
+        behaviorLog("Location Changed, stopping scroll: " +
+          `${document.location.pathname} != ${this.origPath}`, "info");
+        addLink(document.location.href);
+        return;
+      }
+
       const scrollHeight = self.document.scrollingElement.scrollHeight;
 
       if (scrollHeight > lastScrollHeight) {

src/index.ts

@@ -89,7 +89,7 @@ export class BehaviorManager {
       this.behaviors.push(new Autoplay(this.autofetch, opts.startEarly));
     }
 
-    if (self.window.top !== self.window) {
+    if (self.window.top !== self.window && window["__WB_replay_top"] !== self.window) {
       return;
     }
 
@@ -136,9 +136,6 @@ export class BehaviorManager {
     if (this.mainBehavior) {
       this.behaviors.push(this.mainBehavior);
 
-      if (this.mainBehavior instanceof Behavior) {
-
-      }
       if (this.mainBehavior instanceof BehaviorRunner) {
         return this.mainBehavior.behaviorProps.id;
       }
@@ -154,7 +151,7 @@ export class BehaviorManager {
     }
 
     if (typeof(behaviorClass.id) !== "string") {
-      behaviorLog(`Behavior class must have a string string "id" property`, "error");
+      behaviorLog("Behavior class must have a string string \"id\" property", "error");
       return;
     }
 

src/lib/utils.ts

@@ -59,6 +59,12 @@ export function behaviorLog(data, type = "debug") {
   }
 }
 
+export function addLink(url) {
+  if (self["__bx_addLink"]) {
+    self["__bx_addLink"](url);
+  }
+}
+
 export async function openWindow(url) {
   if (self["__bx_open"]) {
     const p = new Promise((resolve) => self["__bx_openResolve"] = resolve);