fix: Sort filtered collection page URLs #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuaYoo
commented
Feb 12, 2025
| @@ -764,11 +764,13 @@ async def list_urls_in_collection( | |||
| crawl_ids = await self.get_collection_crawl_ids(coll_id) | |||
|
|
|||
| match_query: dict[str, object] = {"oid": oid, "crawl_id": {"$in": crawl_ids}} | |||
| sort_query: dict[str, int] = {"count": -1, "_id": 1} | |||
There was a problem hiding this comment.
@tw4l I did a quick pass on this to get it working, feel free to push any suggestions directly!
tw4l
approved these changes
Feb 12, 2025
Unfortunately the way $text works isn't very conducive to our use cases. It reads any special character as a place to split strings for tokenization, so it has completely unusable results for URLs 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2383
Changes
Manual testing
Screenshots
Follow-ups
If we support
$text, we could potentially sort by match score.