Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show additional collection details #2455

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Mar 3, 2025

Resolves #2452

Changes

  • Displays page count and collection size in listing grid
  • Displays month if collection period is in the same year
  • Displays collection size in About > Details section
  • Minor refactor: move byte formatting into localize.ts utility file, move slash (/) separator into own utility file

Screenshots

Page Image/video
Public Collections Gallery Screenshot 2025-03-03 at 12 37 21 PM
Collection details - About Screenshot 2025-03-03 at 12 32 51 PM

@SuaYoo SuaYoo requested review from ikreymer, Shrinks99 and emma-sg March 3, 2025 20:39
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good!

Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ikreymer ikreymer merged commit 65a40c4 into main Mar 3, 2025
27 checks passed
@ikreymer ikreymer deleted the frontend-collections-grid-details branch March 3, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Collections UI fast-follows
4 participants