Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly tests #2460

Merged
merged 8 commits into from
Mar 7, 2025
Merged

Fix nightly tests #2460

merged 8 commits into from
Mar 7, 2025

Conversation

tw4l
Copy link
Member

@tw4l tw4l commented Mar 4, 2025

Fixes #2459

  • Set /data/ as primary storage access_endpoint_url in nightly test chart
  • Modify nightly test GH Actions workflow to spawn a separate job per nightly test module using dynamic matrix
  • Set configuration not to fail other jobs if one job fails
  • Modify failing tests:
    • Add fixture to background job nightly test module so it can run alone
    • Add retry loop to crawlconfig stats nightly test so it's less dependent on timing

GitHub limits each workflow to 256 jobs, so this should continue to be able to scale up for us without issue.

@tw4l tw4l requested a review from ikreymer March 4, 2025 17:22
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
Copy link
Member

@ikreymer ikreymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work fixing these, and adding parallelization!

@ikreymer ikreymer merged commit 13bf818 into main Mar 7, 2025
22 checks passed
@ikreymer ikreymer deleted the nightly-test-fix branch March 7, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix nightly test runs
2 participants