Skip to content

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Sep 23, 2025

Resolves #2840

Changes

  • Adds new "Collections" setting to workflow form, workflow settings, and archived item overview
  • Consistently displays collections list in workflow and archived item settings
  • Renames archived item "Edit Metadata" dialog
  • Fixes collection typing to account for collections without created

Manual testing

Both the app and mkdocs should be running concurrently to test step 4.

  1. Log in as crawler
  2. Go to new workflow. Verify "Collection" is in side navigation
  3. Click "Collection". Verify auto-add field has been moved from the metadata section to the collection section
  4. Click "User Guide". Verify user guide opens to the correct section
  5. Go to edit workflow.
  6. Add a collection. Verify collection is displays as expected, and clicking the arrow button opens the collection a new tab (note: new tab may show 404 page at first, fix is in fix: Prevent showing "not found" page when opening link in new tab #2849)
  7. Remove collection. Verify collection is removed as expected
  8. Add collection and save. Verify new collection is displayed in settings under "Collection" heading
  9. Go to an archived item that is in a collection. Verify list of collection names are displayed in "Collections" section
  10. Click arrow next to collection name. Verify collection opens in new tab
  11. Click pencil icon name to "Collections" heading. Verify dialog opens titled "Edit Archived Item"

Screenshots

Page Image/video
Workflow - Editing Initial:
Screenshot 2025-09-23 at 12 57 31 PM

Added:
Screenshot 2025-09-23 at 12 57 59 PM
Workflow / Settings Screenshot 2025-09-23 at 12 57 09 PM
Archived item / Overview Screenshot 2025-09-23 at 1 55 35 PM
Archived item - Editing Screenshot 2025-09-23 at 1 55 51 PM

Follow-ups

The "Add to collection" component has mostly been left as-is. Improvements to search functionality, like fuzzy search, will be added in followers #2846 and #2845

@SuaYoo SuaYoo force-pushed the frontend-collection-section branch 2 times, most recently from dc692be to b19205e Compare September 23, 2025 16:33
@SuaYoo SuaYoo marked this pull request as ready for review September 23, 2025 21:13
@SuaYoo SuaYoo requested review from ikreymer, emma-sg and tw4l September 23, 2025 21:14
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I saw one overflow issue with the archived item detail page, but I think that can be a separate fix:

Image

Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! And thanks as always for the great testing instructions :)

@ikreymer ikreymer merged commit 6aa0787 into main Sep 26, 2025
29 checks passed
@ikreymer ikreymer deleted the frontend-collection-section branch September 26, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Move "collection auto-add" setting to own section
4 participants