Skip to content

Commit

Permalink
bug with two var delivery
Browse files Browse the repository at this point in the history
  • Loading branch information
Xziy committed Aug 29, 2024
1 parent 6fd5fc6 commit a16c07d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
2 changes: 0 additions & 2 deletions models/Order.js
Original file line number Diff line number Diff line change
Expand Up @@ -1316,10 +1316,8 @@ let Model = {
else {
let deliveryAdapter = await Adapter.getDeliveryAdapter();
await deliveryAdapter.reset(order);
sails.log.debug(order, delivery);
if (order.selfService === false && order.address?.city && order.address?.street && order.address?.home) {
emitter.emit("core:order-check-delivery", order);
let delivery;
try {
delivery = await deliveryAdapter.calculate(order);
}
Expand Down
6 changes: 2 additions & 4 deletions models/Order.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1584,10 +1584,8 @@ let Model = {
} else {
let deliveryAdapter = await Adapter.getDeliveryAdapter();
await deliveryAdapter.reset(order);
sails.log.debug(order, delivery)
if (order.selfService === false && order.address?.city && order.address?.street && order.address?.home) {
emitter.emit("core:order-check-delivery", order);
let delivery: Delivery
try {
delivery = await deliveryAdapter.calculate(order);
} catch (error) {
Expand Down Expand Up @@ -1616,9 +1614,9 @@ let Model = {
delivery.cost = null;
delivery.message = SOFT_DELIVERY_CALCULATION_MESSAGE ?? "Shipping cost cannot be calculated";
}

order.delivery = delivery;

if (order.delivery && isValidDelivery(order.delivery, softDeliveryCalculation)) {
if (!order.delivery.item) {
order.deliveryCost = order.delivery.cost
Expand Down

0 comments on commit a16c07d

Please sign in to comment.