Skip to content

Commit

Permalink
test: ignore CHROME_BIN/FIREFOX_BIN environment variables
Browse files Browse the repository at this point in the history
CHROME_BIN already exists on github actions, avoiding the download of the beta/canary version.
Also use path.join to join path to browser
  • Loading branch information
fippo committed Apr 20, 2024
1 parent 1ee2f65 commit 42d3a29
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions test/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
'use strict';

const os = require('os');
const path = require('path');
const puppeteerBrowsers = require('@puppeteer/browsers');

async function download(browser, version, cacheDir, platform) {
Expand All @@ -24,7 +25,7 @@ async function download(browser, version, cacheDir, platform) {
}

module.exports = async(config) => {
const cacheDir = process.cwd() + '/browsers';
const cacheDir = path.join(process.cwd(), 'browsers');
const platform = puppeteerBrowsers.detectBrowserPlatform();

let browsers;
Expand Down Expand Up @@ -58,13 +59,13 @@ module.exports = async(config) => {
'/Contents/MacOS/Safari Technology Preview';
}

if (browsers.includes('firefox') && !process.env.FIREFOX_BIN) {
if (browsers.includes('firefox')) {
const buildId = await download('firefox', process.env.BVER || 'stable',
cacheDir, platform);
process.env.FIREFOX_BIN = puppeteerBrowsers
.computeExecutablePath({browser: 'firefox', buildId, cacheDir, platform});
}
if (browsers.includes('chrome') && !process.env.CHROME_BIN) {
if (browsers.includes('chrome')) {
const buildId = await download('chrome', process.env.BVER || 'stable',
cacheDir, platform);
process.env.CHROME_BIN = puppeteerBrowsers
Expand Down

0 comments on commit 42d3a29

Please sign in to comment.