Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: ignore CHROME_BIN/FIREFOX_BIN environment variables #1157

Merged
merged 1 commit into from
Apr 20, 2024
Merged

test: ignore CHROME_BIN/FIREFOX_BIN environment variables #1157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
'use strict';

const os = require('os');
const path = require('path');
const puppeteerBrowsers = require('@puppeteer/browsers');

async function download(browser, version, cacheDir, platform) {
Expand All @@ -24,7 +25,7 @@ async function download(browser, version, cacheDir, platform) {
}

module.exports = async(config) => {
const cacheDir = process.cwd() + '/browsers';
const cacheDir = path.join(process.cwd(), 'browsers');
const platform = puppeteerBrowsers.detectBrowserPlatform();

let browsers;
Expand Down Expand Up @@ -58,13 +59,13 @@ module.exports = async(config) => {
'/Contents/MacOS/Safari Technology Preview';
}

if (browsers.includes('firefox') && !process.env.FIREFOX_BIN) {
if (browsers.includes('firefox')) {
const buildId = await download('firefox', process.env.BVER || 'stable',
cacheDir, platform);
process.env.FIREFOX_BIN = puppeteerBrowsers
.computeExecutablePath({browser: 'firefox', buildId, cacheDir, platform});
}
if (browsers.includes('chrome') && !process.env.CHROME_BIN) {
if (browsers.includes('chrome')) {
const buildId = await download('chrome', process.env.BVER || 'stable',
cacheDir, platform);
process.env.CHROME_BIN = puppeteerBrowsers
Expand Down