feat(WOR-TSK-194): implement bumpSnapshot NAPI function #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelramos
added
♨️ ACTION: pull request
- Add bumpSnapshot function for generating temporary snapshot versions
- Support format template with variables: {version}, {branch}, {short_commit}, {commit}, {timestamp}
- Validate snapshot format contains at least one valid variable
- Snapshots do NOT consume/archive changesets (no_archive=true, no_changelog=true)
- Return packages with originalVersion and snapshotVersion
Implementation details:
- convert_to_napi_snapshot: Convert CLI response to NAPI types
- parse_snapshot_response: Parse JSON from CLI to BumpSnapshotData
- validate_snapshot_params: Validate root path and snapshot format
- convert_snapshot_params_to_args: Convert NAPI params to CLI args
- DEFAULT_SNAPSHOT_FORMAT constant: {version}-snapshot.{short_commit}
Tests:
- Add 50 comprehensive tests for bumpSnapshot
- shared_buffer_tests (6 tests)
- parse_response_tests (10 tests)
- conversion_tests (8 tests)
- validation_tests (17 tests)
- bump_types_tests (9 existing tests)
Node.js bindings:
- Regenerate bindings with build-binding:release
- Update index.ts exports with bumpSnapshot function
- Update TypeScript type definitions
Story 5.4 complete - all 746 tests passing, 0 clippy warnings
miguelramos
force-pushed
the
feat/WOR-TSK-194-BUMP-SBAPSHOT
branch
from
ab36797 to
6150a15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation details:
Tests:
Node.js bindings:
Story 5.4 complete - all 746 tests passing, 0 clippy warnings