feat(WOR-TSK-202): implement config types for Node.js bindings #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 16, 2025 05:44
Implement comprehensive NAPI-compatible type definitions for config commands: Input Parameters: - ConfigShowParams: parameters for configShow command - ConfigValidateParams: parameters for configValidate command Configuration Structures: - ConfigData: main configuration container - ChangesetConfigInfo: changeset management settings - VersionConfigInfo: version resolution settings - DependencyConfigInfo: dependency propagation settings - UpgradeConfigInfo: upgrade detection settings - RegistryConfigInfo: NPM registry configuration - ScopedRegistryEntry: scoped registry mapping - BackupConfigInfo: backup and rollback settings - ChangelogConfigInfo: changelog generation settings - AuditConfigInfo: audit and health check settings - AuditSectionsConfigInfo: audit section flags - HealthScoreWeightsInfo: health score weights - GitConfigInfo: git integration settings - ExecuteConfigInfo: command execution settings Response Data: - ConfigShowData: loaded configuration response - ConfigValidateData: validation results response - ConfigValidationIssue: individual validation issue API Responses: - ConfigShowApiResponse: wrapper for configShow - ConfigValidateApiResponse: wrapper for configValidate Constants: - VALID_STRATEGIES, VALID_BUMP_TYPES, VALID_CHANGELOG_FORMATS - VALID_MONOREPO_MODES, VALID_SEVERITY_LEVELS All types include comprehensive documentation, Default implementations, builder methods, and proper NAPI attributes for TypeScript generation.
Update types/mod.rs to export all config types: - ConfigShowParams, ConfigValidateParams - ConfigShowData, ConfigValidateData - ConfigShowApiResponse, ConfigValidateApiResponse - ConfigValidationIssue, ConfigData - All configuration section types (ChangesetConfigInfo, etc.) - Validation constants Types are marked with allow(unused_imports) as they will be used in stories 7.2-7.3 (config commands implementation).
Add 78 new tests across 7 test modules: - config_params_tests: ConfigShowParams and ConfigValidateParams - config_info_tests: all configuration section structures - config_data_tests: ConfigData and ConfigShowData - config_validation_tests: ConfigValidationIssue and ConfigValidateData - config_api_response_tests: API response wrappers - config_constants_tests: validation constants - config_scenario_tests: complete workflow scenarios Tests cover: - Construction and default values - Builder methods and factory functions - Clone and serialization - Error and success scenarios - Complete config show/validate workflows Total test count: 914 (78 new tests added)
Regenerate binding.d.ts and binding.js with new config types. TypeScript definitions now include: - ConfigShowParams, ConfigValidateParams - ConfigShowData, ConfigValidateData - ConfigShowApiResponse, ConfigValidateApiResponse - ConfigValidationIssue, ConfigData - All configuration section interfaces Fixed documentation to use line comments instead of JSDoc in TypeScript examples to prevent parsing errors.
Update public API exports to include all config types: Input Parameters: - ConfigShowParams, ConfigValidateParams Response Data: - ConfigShowData, ConfigValidateData API Responses: - ConfigShowApiResponse, ConfigValidateApiResponse Validation Types: - ConfigValidationIssue Main Configuration: - ConfigData Configuration Sections: - ChangesetConfigInfo, VersionConfigInfo - DependencyConfigInfo, UpgradeConfigInfo - RegistryConfigInfo, ScopedRegistryEntry - BackupConfigInfo, ChangelogConfigInfo - AuditConfigInfo, AuditSectionsConfigInfo - HealthScoreWeightsInfo, GitConfigInfo - ExecuteConfigInfo
Run napi version to synchronize platform-specific package versions with the main workspace-tools package.
miguelramos
added
♨️ ACTION: pull request
Apply cargo fmt to fix import ordering in tests.rs. Fix clippy::field_reassign_with_default by using struct update syntax instead of mutable reassignment after Default::default().
miguelramos
force-pushed
the
feat/WOR-TSK-202-CONFIG-TYPES
branch
from
834a827 to
a885351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.