feat(WOR-TSK-203): implement configShow NAPI function #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 5, 2026 12:19
- Add discover_config_file async function for config file discovery - Add conversion functions from pkg config types to NAPI types - Implement config_show async function with parameter validation - Support all config sections: changeset, version, dependency, upgrade, changelog, audit, git, execute - Handle config file formats: JSON, TOML, YAML - Add TODO placeholder for configValidate (Story 7.3)
- Add config_show export in commands/mod.rs - Re-export config_show in lib.rs for public API - Update TODO comments to reflect Story 7.2 completion
- Add validation tests for root path and config path parameters - Add format conversion tests for JSON, TOML, YAML - Add type conversion tests for all config sections - Add params builder tests for ConfigShowParams - Add discovery tests for config file paths - Add default values tests verifying pkg crate defaults - Total: 34 new tests for config_show functionality
- Add configShow function export in binding.js - Generate TypeScript definitions for ConfigShowParams, ConfigShowApiResponse, ConfigShowData and ConfigData types - Include all configuration section types in binding.d.ts
- Import configShow from binding module - Export configShow for public API - Update module documentation with Story 7.2 reference
- Add Configuration section to Overview - Add configShow to Core Functions table - Add new Config Functions section with table - Add detailed API documentation for configShow - Include ConfigShowParams, ConfigShowData, ConfigData interfaces - Add usage examples with basic and custom config path - Update TypeScript Support section with config types
- Update configShow acceptance criteria checkbox to [x]
- Update version in main package.json - Update versions in all npm platform packages
miguelramos
added
♨️ ACTION: pull request
…dule - Add #[allow(clippy::unwrap_used)] to permit unwrap() in tests - Add #[allow(clippy::expect_used)] to permit expect() in tests - Replace "".to_string() with String::new() per clippy::manual_string_new This follows the same pattern used by other test modules (e.g., status_tests) and fixes CI pipeline clippy errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog, audit, git, execute