fix(bump): include archived changesets in git commit #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bump command was archiving changesets correctly (moving files from .changesets/ to .changesets/history/) but these filesystem changes were not being included in the git commit. This caused archived changeset files to remain in the remote repository after a release. Root cause: The modified_files list passed to commit_version_changes only contained package.json and CHANGELOG.md files, not the changeset archive operations (deletion of original + creation of archived file). Changes: - Add ArchiveResult struct to track paths affected by archive operation - Modify ChangesetStorage::archive trait to return ArchiveResult - Add Repo::remove() method for staging deleted files - Update commit_version_changes to handle both additions and deletions - Capture archive paths in execute_bump_apply and add to modified_files Additional fixes: - Add missing Repo import in changeset/update.rs - Remove unused PackageToolsConfig import in changeset/add.rs - Fix clippy format_push_string warnings in commands/mod.rs BREAKING CHANGE: ChangesetStorage::archive now returns ChangesetResult<ArchiveResult> instead of ChangesetResult<()>
miguelramos
added
♨️ ACTION: pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bump command was archiving changesets correctly (moving files from .changesets/ to .changesets/history/) but these filesystem changes were not being included in the git commit. This caused archived changeset files to remain in the remote repository after a release.
Root cause: The modified_files list passed to commit_version_changes only contained package.json and CHANGELOG.md files, not the changeset archive operations (deletion of original + creation of archived file).
Changes:
Additional fixes:
BREAKING CHANGE: ChangesetStorage::archive now returns ChangesetResult instead of ChangesetResult<()>