feature: workspace fs configuration module #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elds Implement the FileSystemConfig struct with comprehensive timeout configuration: - FileSystemConfig struct with read_timeout, write_timeout, operation_timeout fields - Default implementation with PRD-specified values (30s, 30s, 60s) - Debug + Clone trait implementations - Getter methods (#[must_use]) for all timeout fields - Static assertions for Send + Sync thread safety - FileSystemConfigBuilder with fluent builder pattern - Comprehensive unit tests (29 tests) covering: - Default timeout values match PRD specification - Getter methods return correct values - Builder pattern functionality and method chaining - Edge cases (zero duration, max duration, subsecond) - Thread safety verification Note: Added clippy exception for struct_field_names as the _timeout suffix follows common Rust ecosystem conventions (tokio, reqwest) and is required by the PLAN.md specification. Closes: workspace-node-tools-g2t.1
Apply clippy::uninlined_format_args suggestion - use variables directly
in format string (e.g., format!("{config:?}") instead of format!("{:?}", config)).
miguelramos
added
♨️ ACTION: pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.