feat(workspace-fs): implement PathExt trait with normalize() method #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the PathExt trait for synchronous path normalization without I/O: - Add PathExt trait extending std::path::Path with normalize() method - Implement for both Path and PathBuf types - Resolve . (current dir) and .. (parent dir) components logically - Handle edge cases: empty paths, multiple parent dirs, root paths - Preserve parent dirs for relative paths going above start - Support Windows drive prefixes (C:) with platform-specific tests - Handle Unicode paths and special characters - Comprehensive documentation with examples for all scenarios - 46 unit tests covering absolute, relative, edge cases, and complex scenarios - Public re-export of PathExt trait from crate root Algorithm correctly handles: - /a/b/../c -> /a/c (absolute with parent) - ./a/./b -> a/b (relative with current dir) - a/b/../../c -> c (resolution to single component) - ../../file -> ../../file (preserved parent dirs) - Empty path -> . (current directory) Closes: workspace-node-tools-60y.1
miguelramos
added
♨️ ACTION: pull request
On Windows, paths starting with / are 'rooted' but not absolute. Absolute paths on Windows require a drive prefix (e.g., C:\). Split test into Unix and Windows variants with appropriate paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the PathExt trait for synchronous path normalization without I/O:
Algorithm correctly handles:
Closes: workspace-node-tools-60y.1