fix: normalize relative paths to remove leading ./ before passing to git2 #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…git2 git2's index operations (add_path, remove_path) fail with error 'should not start with `.'`' when given paths starting with './'. This occurred during bump --execute with changeset archiving when the workspace root was '.'. The fix normalizes relative paths in three locations: - cli/commands/bump/git_integration.rs: strip ./ from relative paths before staging files for commit - git/repo.rs: strip ./ in add() and remove() methods as defense in depth Added comprehensive unit tests for path normalization in both crates.
miguelramos
added
♨️ ACTION: pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git2's index operations (add_path, remove_path) fail with error 'should not start with
.'' when given paths starting with './'. This occurred during bump --execute with changeset archiving when the workspace root was '.'.The fix normalizes relative paths in three locations:
Added comprehensive unit tests for path normalization in both crates.