Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a mqtt gateway plugin #64

Closed
wants to merge 6 commits into from
Closed

add a mqtt gateway plugin #64

wants to merge 6 commits into from

Conversation

atorber
Copy link
Contributor

@atorber atorber commented Jan 17, 2024

一个微信远程调用插件,使用MQTT连接本地或云端Wechaty客户端实现远程操作

https://www.yuque.com/atorber/chatflow/hwqf0tgqg9o51epc

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 17, 2024
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please submit the linting fixes in another PR.

This PR should only include the MQTT related code modifications.

@@ -59,11 +68,6 @@
"url": "https://github.com/wechaty/plugin-contrib/issues"
},
"homepage": "https://github.com/wechaty/plugin-contrib#readme",
"git": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you remove the git hook?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an error because I deleted it during submission and forgot to restore it afterwards.

@@ -54,7 +54,7 @@ test('isMatchConfig {mention: false}', async t => {

const mentionMessage = await new Promise<Message>(resolve => {
room.once('message', resolve)
fixture.mocker.player.say('ding', [fixture.mocker.bot]).to(fixture.mocker.room)
fixture.mocker.player.say('ding', [ fixture.mocker.bot ]).to(fixture.mocker.room)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please submit another PR to fix the linting, instead of including the lining fixes in this PR, to make this PR only related to the MQTT plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will do it later and close this pull.

@@ -21,10 +21,15 @@ test('integration testing', async t => {

test('plugin name', async t => {
for (const plugin of Object.values(plugins)) {
console.info('plugin.name:', plugin)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the unnecessary console.info

@atorber atorber closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants