Upkeep - improve messages + CI #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove deprecated `expect_that()`, `expect_is()` -> `expect_type()` or `expect_s3_class()`
… logo.png for pkgdown to recognize it. redocument()
…e it easier in RStudio).
…n't know out of the box which version will come up)
olivroy
commented
Jun 11, 2024
|
Thanks @olivroy ! Can you rerun? |
|
You can accept workflow run to see if everything works! I will also run locally |
|
@gmyenni I can confirm that everything passes cleanly on my end locally. Can't reproduce the failures encountered on CI. |
|
@gmyenni I just noticed that you weren't testing on macOS before. I will revert that change. I still don't know what is causing the R-devel problem, but it is unrelated to this PR. |
olivroy
commented
Aug 6, 2024
Clean up workflow PR
henrykironde
approved these changes
Aug 8, 2024
|
I will merge these changes and we solve the na.strings = c("", "NA"), in a new PR |
|
@henrykironde there may be one other action required from you regarding the test-coverage action. codecov now requires a token to be set. You can set a repo or organization token by following the instructions here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests won't pass because of #298Fixes #295
Otherwise, use cli for messaging
use testthat 3rd edition (use snapshot test for message validation + other lints)
Update gh actions with
usethis::use_github_action()Update pkgdown to use bootstrap 5 (adds a search bar)
FIx a tidyselect deprecation warning
Make format_*() functions redundant (no longer used in the package)
Happy to answer any questions you may have!
cli has the advantage of detecting automatically if it should do ansi output and fallbacks otherwise. This means that if you are using RStudio (or a terminal that supports links), test output is now clickable (as you can see, I was able to get rid of setup.R and teardown.R
R CMD CHECK passes cleanly locally
except for the test failure