add unit test

weibocom · Feb 28, 2024 · 0156403 · 0156403
1 parent 116aadd
commit 0156403
Showing 1 changed file with 28 additions and 5 deletions.
diff --git a/...-impl/src/test/groovy/com/weibo/rill/flow/impl/service/TaskTemplateServiceImplTest.groovy b/...-impl/src/test/groovy/com/weibo/rill/flow/impl/service/TaskTemplateServiceImplTest.groovy
@@ -10,6 +10,8 @@ import com.weibo.rill.flow.task.template.dao.model.TaskTemplateDO
 import com.weibo.rill.flow.task.template.model.TaskTemplate
 import com.weibo.rill.flow.task.template.model.TaskTemplateParams
 import spock.lang.Specification
+import spock.lang.Unroll
+
 /**
  * TaskTemplateServiceImpl 测试类
  */
@@ -265,24 +267,45 @@ class TaskTemplateServiceImplTest extends Specification {
         taskTemplate.getMetaData().getFields() == ["field1": "field1", "field2": "field2"]
     }
 
-    def "test checkTaskTemplateDOValid when taskTemplateDO is null or taskTemplateDO.name is null or taskTemplateDO.type is null"() {
+    @Unroll
+    def "test checkTaskTemplateDOValid when taskTemplateDO.name is null"() {
         given:
         TaskTemplateDO taskTemplateDO1 = Mock(TaskTemplateDO)
         taskTemplateDO1.getName() >> null
+        when:
+        taskTemplateService.checkTaskTemplateDOValid(taskTemplateDO1)
+        then:
+        thrown(IllegalArgumentException)
+    }
+
+    def "test checkTaskTemplateDOValid when taskTemplateDO is null"() {
+        when:
+        taskTemplateService.checkTaskTemplateDOValid(null)
+        then:
+        thrown(IllegalArgumentException)
+    }
+
+    def "test checkTaskTemplateDOValid when taskTemplateDO.type is null"() {
+        given:
         TaskTemplateDO taskTemplateDO2 = Mock(TaskTemplateDO)
         taskTemplateDO2.getName() >> "taskTemplate2"
         taskTemplateDO2.getType() >> null
+        when:
+        taskTemplateService.checkTaskTemplateDOValid(taskTemplateDO2)
+        then:
+        thrown(IllegalArgumentException)
+    }
+
+    def "test checkTaskTemplateDOValid when taskTemplateDO.category is invalid"() {
+        given:
         TaskTemplateDO taskTemplateDO3 = Mock(TaskTemplateDO)
         taskTemplateDO3.getName() >> "taskTemplate3"
         taskTemplateDO3.getType() >> 1
         taskTemplateDO3.getCategory() >> "xxx"
         when:
-        taskTemplateService.checkTaskTemplateDOValid(null)
-        taskTemplateService.checkTaskTemplateDOValid(taskTemplateDO1)
-        taskTemplateService.checkTaskTemplateDOValid(taskTemplateDO2)
         taskTemplateService.checkTaskTemplateDOValid(taskTemplateDO3)
         then:
-        thrown IllegalArgumentException
+        thrown(IllegalArgumentException)
     }
 
     def "test turnTaskTemplateDOToTaskTemplate"() {