🎨 Initial CogReader struct with decoder field #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defining a Cloud-Optimized GeoTIFF Reader struct with a decoder field containing an instance of tiff::decoder::Decoder with an unlimited decoding buffer size by default. Marking the struct as private for now until more method implementations are done.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining a Cloud-Optimized GeoTIFF Reader struct with a decoder field containing an instance of
tiff::decoder::Decoderwith an unlimited decoding buffer size by default.Note that this struct is marked as private for now until more method implementations are done. Still debating on what are considered core fields/attributes for GeoTIFFs (affine transformation?), and what are 'optional'.
And yes, this struct should ideally be upstreamed somehow to https://github.com/georust/geotiff or somewhere, but I'm gonna experiment with different APIs over the next few weeks first.
References: