Skip to content

Commit

Permalink
fix: remove rollup-plugin-sourcemaps
Browse files Browse the repository at this point in the history
it does not support rollup v3 yet.
refs: maxdavidson/rollup-plugin-sourcemaps#127
  • Loading branch information
aladdin-add committed Mar 23, 2023
1 parent aa5493e commit c327e5e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@
"rollup": "^3.20.0",
"rollup-plugin-delete": "^2.0.0",
"rollup-plugin-dts": "^5.3.0",
"rollup-plugin-sourcemaps": "^0.6.3",
"rollup-plugin-typescript2": "^0.34.1",
"sade": "^1.8.1",
"semver": "^7.3.8",
Expand Down
6 changes: 4 additions & 2 deletions src/createRollupConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import replace from '@rollup/plugin-replace';
import resolve, {
DEFAULTS as RESOLVE_DEFAULTS,
} from '@rollup/plugin-node-resolve';
import sourceMaps from 'rollup-plugin-sourcemaps';
// import sourceMaps from 'rollup-plugin-sourcemaps';
import typescript from 'rollup-plugin-typescript2';
import ts from 'typescript';
import path from 'path';
Expand Down Expand Up @@ -207,7 +207,9 @@ export async function createRollupConfig(
'process.env.NODE_ENV': JSON.stringify(opts.env),
preventAssignment: true,
}),
sourceMaps(),
// removed as it does not support rollup v3 yet.
// TODO: we could move to babel's inputSourceMap option(as it is supported in its readme)
// sourceMaps(),
shouldMinify &&
terser({
output: { comments: false },
Expand Down

0 comments on commit c327e5e

Please sign in to comment.